search

zf1s / zf1

Monorepo of a fork of Zend Framework 1, with all components split into individual composer packages. PHP 5.3-8.3 compatible.
BSD 3-Clause "New" or "Revised" License
59 stars 22 forks source link

Fix str_split('') logic to keep same as PHP before 8.2 on PHP 8.2 #143

Closed glensc closed 1 year ago

glensc commented 1 year ago

Carries https://github.com/Shardj/zf1-future/pull/277 which picked only relevant change from https://github.com/Shardj/zf1-future/pull/275 which was created by @hungtrinh

Reference:

Fixes:

falkenhawk commented 1 year ago

Thanks! We will look into it after #141 and #145

glensc commented 1 year ago

Unrelated to https://github.com/zf1s/zf1/pull/141 and https://github.com/zf1s/zf1/pull/145 both

partikus commented 1 year ago

@falkenhawk IMHO looks fine. It can be merged even for php 8.1 support.

https://3v4l.org/mHMvb