Closed partikus closed 1 year ago
@partikus please rebase this branch onto php81-compat
branch
@falkenhawk rebased & updated
rebased 🆙
should wait for php81-compat
branch merged, or rebased to master
and change the target branch to master
. so not giving my approve :)
@glensc thanks for the review 👍
The plan is to merge this PR as a part of 8.1
improvements. So this PR targets php8.1-compat
instead of master
.
I'm wondering ... maybe
php8.1-compat
onto master
php8.1-compat
as a part of PHP 8.1 adjustmentsThough, it complicates the flow soo much.
what do you think guys? @falkenhawk @marcing
edit: IMHO it can wait till #149 is merged
@partikus we'll merge #149 first once it's approved, then this PR straight to master
for the record:
before: Tests: 16125, Assertions: 63458, Incomplete: 21, Skipped: 591.
after: Tests: 16676, Assertions: 65023, Incomplete: 24, Skipped: 609.
@partikus could we also include https://github.com/Shardj/zf1-future/pull/284 please?
Carrying it: https://github.com/zf1s/zf1/pull/160
since
pdo_sqlite
extension is installed, we could start supportingsqlite
tests on CISince PHP 8.1 introduced BC break while returning php types instead of strings, we have to revert the previous configuration. Overwritten attribute
\PDO::ATTR_STRINGIFY_FETCHES => true
can be still changed through the['driver_options' => [\PDO::ATTR_STRINGIFY_FETCHES => false]]
config for sqlite adapter.