zf1s / zf1

Monorepo of a fork of Zend Framework 1, with all components split into individual composer packages. PHP 5.3-8.3 compatible.
BSD 3-Clause "New" or "Revised" License
57 stars 22 forks source link

[github-actions] enable SQLite tests #157

Closed partikus closed 1 year ago

partikus commented 1 year ago

since pdo_sqlite extension is installed, we could start supporting sqlite tests on CI

Since PHP 8.1 introduced BC break while returning php types instead of strings, we have to revert the previous configuration. Overwritten attribute \PDO::ATTR_STRINGIFY_FETCHES => true can be still changed through the ['driver_options' => [\PDO::ATTR_STRINGIFY_FETCHES => false]] config for sqlite adapter.

falkenhawk commented 1 year ago

@partikus please rebase this branch onto php81-compat branch

partikus commented 1 year ago

@falkenhawk rebased & updated

partikus commented 1 year ago

rebased 🆙

glensc commented 1 year ago

should wait for php81-compat branch merged, or rebased to master and change the target branch to master. so not giving my approve :)

partikus commented 1 year ago

@glensc thanks for the review 👍

The plan is to merge this PR as a part of 8.1 improvements. So this PR targets php8.1-compat instead of master. I'm wondering ... maybe

  1. creating a new PR for #437e349
  2. merge new PR to master
  3. rebase php8.1-compat onto master
  4. merge #21088d64 to php8.1-compat as a part of PHP 8.1 adjustments

Though, it complicates the flow soo much.

what do you think guys? @falkenhawk @marcing

edit: IMHO it can wait till #149 is merged

falkenhawk commented 1 year ago

@partikus we'll merge #149 first once it's approved, then this PR straight to master

falkenhawk commented 1 year ago

for the record: before: Tests: 16125, Assertions: 63458, Incomplete: 21, Skipped: 591. after: Tests: 16676, Assertions: 65023, Incomplete: 24, Skipped: 609.

falkenhawk commented 1 year ago

@partikus could we also include https://github.com/Shardj/zf1-future/pull/284 please?

glensc commented 1 year ago

Carrying it: https://github.com/zf1s/zf1/pull/160