Closed fredericgboutin-yapla closed 1 year ago
ideally:
Co-Authored-By: Original Author <their@email.xx>
in git trailer, or git commit --amend "Original Author their@email.xx" and Co-Authored-By
the second author who made this commitmaster
branch.but I guess it's ok as well if maintainers just use github squash merge option and fill the Co-Authored-By
as git trailer manually in commit message.
@fredericgboutin-yapla you could also remove the two unwanted commits from your master and force push
git reset --hard eb369bf843c3c01385adde1c246daac7eccc2977
git push --force-with-lease
I'm grateful for your remarks. TBH this is literally the first time I'm contributing on a project like this. Is there anything I should've read first?
I started from scratch using Github Desktop - https://github.com/zf1s/zf1/pull/164
cross-link the PR's as well, saying in new pr body: Replaces <link to the old pr>
also worth to tag the username of original commit there as well: Originally submitted to zf1-future by @githubaccount
I'm struggling to find any original pull request or PR 😓
if you click on the commit it's the master (#23)
From https://github.com/Shardj/zf1-future/commit/9175301058d324bcdcdca0d091b2e6c394273a95