search

zf1s / zf1

Monorepo of a fork of Zend Framework 1, with all components split into individual composer packages. PHP 5.3-8.3 compatible.
BSD 3-Clause "New" or "Revised" License
57 stars 22 forks source link

php8.2 compat: add missing class properties #170

Closed falkenhawk closed 6 months ago

falkenhawk commented 1 year ago

ported from https://github.com/Shardj/zf1-future/pull/278, https://github.com/Shardj/zf1-future/pull/289 and https://github.com/Shardj/zf1-future/pull/291 thanks @hungtrinh @glensc !

And added more fixes on top, which were not covered by the mentioned PRs.

Mitigate deprecation errors Deprecated: Creation of dynamic property {x} is deprecated which is thrown in php 8.2 and which are going to become fatal errors in php 9.

php 8.2 requires all properties to be declared before using them. https://php.watch/versions/8.2/dynamic-properties-deprecated

replaces https://github.com/zf1s/zf1/pull/145 and https://github.com/zf1s/zf1/pull/169

followup to allow dynamic props in Zend_Form, Zend_Form_Element and Zend_View_Abstract ➡ #180

fredericgboutin-yapla commented 11 months ago

For what it is worth, I tried this branch and now all my 500 unit tests are passing and my website works on PHP 8.2.

Keep up the great work 👍 🙏

Voltisky commented 11 months ago

Is there a release plan? Maybe some help is needed to speed up the implementation process.

falkenhawk commented 11 months ago

Sure, any help would be greatly appreciated :)

There are still 3 failures and 200+ errors, see the php 8.2 workflow. @maksimovic addressed memcache issues in #169 but those fixes still need to be extracted to a separate PR.

Most of the issues are triggered by accessing dynamic props on Zend view and form element.

And there are a bunch of smaller ones.

Voltisky commented 11 months ago

Sure, any help would be greatly appreciated :)

There are still 3 failures and 200+ errors, see the php 8.2 workflow. @maksimovic addressed memcache issues in #169 but those fixes still need to be extracted to a separate PR.

Most of the issues are triggered by accessing dynamic props on Zend view and form element.

And there are a bunch of smaller ones.

Good. We will probably have resources to help prepare for PHP 8.2. Can we separate specific feature to work on ?

4ndrzej commented 7 months ago

I can help, but could you please guide me on how I can get started and what should I do?

falkenhawk commented 6 months ago

1.15.3 is released now, bringing compatibility with php 8.2 & 8.3.