It looks like it's safe to use the #[AllowDynamicProperties] attribute, and it should still be valid for php 9.0 and not throw an error, contrary to what I understood at first.
As per RFC:
https://wiki.php.net/rfc/deprecate_dynamic_properties#proposal "The creation of dynamic properties on classes that aren't marked with the #[AllowDynamicProperties] attribute is deprecated in PHP 8.2 and becomes an Error exception in PHP 9.0."
followup to #170
It looks like it's safe to use the
#[AllowDynamicProperties]attribute, and it should still be valid for php 9.0 and not throw an error, contrary to what I understood at first.As per RFC: https://wiki.php.net/rfc/deprecate_dynamic_properties#proposal "The creation of dynamic properties on classes that aren't marked with the #[AllowDynamicProperties] attribute is deprecated in PHP 8.2 and becomes an Error exception in PHP 9.0."
Related issues from zf1-future where they went with refactoring those classes to use a defined property to store all previously dynamic props in an array, which introduced breaking changes: https://github.com/Shardj/zf1-future/issues/307#issuecomment-1430108870 https://github.com/Shardj/zf1-future/pull/261 https://github.com/Shardj/zf1-future/pull/268 https://github.com/Shardj/zf1-future/issues/328 https://github.com/Shardj/zf1-future/pull/329