zf1s / zf1

Monorepo of a fork of Zend Framework 1, with all components split into individual composer packages. PHP 5.3-8.3 compatible.
BSD 3-Clause "New" or "Revised" License
58 stars 22 forks source link

Merge with zf1-future #25

Open glensc opened 4 years ago

glensc commented 4 years ago

Merge efforts with shardj/zf1-future project:

Seems they have gone further original plan to support modern PHP: Minimum version required is PHP 7.4.

Also, it lacks package splitting, which I love in zf1s.

So the project goals are not the same, but there may be large overlapping efforts.

x-ref:

glensc commented 4 years ago

They were thinking restoring backward compat from 7.0:

but seems now their minimum is 7.4 instead...

Shardj commented 3 years ago

It should still be 7.0 minimum, I don't think 7.4 has ever been the minimum. If it was I'd be pretty screwed since all of my systems were on 7.2 until this morning

glensc commented 2 years ago

carry status: 2022-10-04

already applied

carried

more work needed

irrelevant

Shardj commented 2 years ago

Lots of respect for the amount of work you do for zf1s and the help you provide to zf1-future @glensc

glensc commented 1 year ago

Some unknown files committed in (origin and author unclear):

glensc commented 1 year ago

@falkenhawk I was trying to cherry-pick some PHP 8.1 changes from zf1-future, and it seemed need to cherry-pick some earlier changes, so ended up picking:

it seemed like a good change, and harmless (just phpdoc changes), but it already assumes some preceding changes being applied:

shall I continue? as they already discussed there the exact thing, it makes code diverged a lot, after these two the differences should be smaller. indeed picking 104 may introduce another (larger) pull request to apply.

sreichel commented 1 year ago

shall I continue?

Please.

glensc commented 1 year ago

shall I continue?

Please.

Maintainers here rejected picking up formatting changes from zf1-future, so that was declined:

sreichel commented 1 year ago

To bad. It would be really nice to have it synced with zf1-future.