main.scons has a typo

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Obtain a copy of libjingle 0.5.4 source code from SVN or "downloads" section 
in this website

What is the expected output? What do you see instead?
invoke "hammer.bat --mode=all --vsproj" can't get the expected output.

What version of the product are you using? On what operating system?
VS2010, Windows 7 64bit

Please provide any additional information below.
File "main.scons", line 504:
    projects = [p],
I guess that should be a typo of
    project = [p],

Original issue reported on code.google.com by studentt...@gmail.com on 15 May 2011 at 3:23

[GoogleCodeExporter]

This is not the problem. Have you made change to the following line?

# 'libjingle',  # Please uncomment this line if you build VS proj files.

Please reopen this issue if you still have problem getting proj files

Original comment by jun...@google.com on 23 May 2011 at 9:48

• Changed state: Done

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I get problem even I unremark that
=====================================
C:\libjingle\trunk\talk>c:\swtoolkit\hammer.bat --mode=all --vsproj
scons: Reading SConscript files ...

scons: warning: The build_dir keyword has been deprecated; use the variant_dir k
eyword instead.
File "c:\swtoolkit\site_scons\site_init.py", line 203, in BuildEnvironmentSConsc
ripts

scons: warning: The build_dir keyword has been deprecated; use the variant_dir k
eyword instead.
File "c:\swtoolkit\site_scons\site_init.py", line 203, in BuildEnvironmentSConsc
ripts

scons: warning: The build_dir keyword has been deprecated; use the variant_dir k
eyword instead.
File "c:\swtoolkit\site_scons\site_init.py", line 203, in BuildEnvironmentSConsc
ripts
***Unfortunately the vsproj creator isn't smart enough to
***automatically get the correct output locations.  It is very easy
***though to change it in the properties pane to the following
***($SolutionDir)/build/<foo>/staging/<bar>.exe
scons: done reading SConscript files.
scons: Building targets ...
ComponentVSDirProjectBuilder(["flute_source.vcproj"], [])
  Scanning directories for source...
scons: *** [flute_source.vcproj] IndexError : string index out of range
Traceback (most recent call last):
  File "C:\scons-2.0.1\scons-local-2.0.1\SCons\Action.py", line 1046, in execute

    result = self.execfunction(target=target, source=rsources, env=env)
  File "c:\swtoolkit\site_scons\site_tools\component_targets_msvs.py", line 604,
 in ComponentVSDirProjectBuilder
    suffixes=env.SubstList2('$COMPONENT_VS_SOURCE_SUFFIXES'))
  File "c:\swtoolkit\site_scons\site_tools\component_targets_msvs.py", line 564,
 in FindSources
    source_nodes = env.Glob(source_entry)
  File "C:\scons-2.0.1\scons-local-2.0.1\SCons\Environment.py", line 1962, in Gl
ob
    return self.fs.Glob(self.subst(pattern), ondisk, source, strings)
  File "C:\scons-2.0.1\scons-local-2.0.1\SCons\Node\FS.py", line 1291, in Glob
    return cwd.glob(pathname, ondisk, source, strings)
  File "C:\scons-2.0.1\scons-local-2.0.1\SCons\Node\FS.py", line 1897, in glob
    return sorted(self._glob1(basename, ondisk, source, strings),
  File "C:\scons-2.0.1\scons-local-2.0.1\SCons\Node\FS.py", line 1954, in _glob1

    if pattern[0] != '.':
IndexError: string index out of range
scons: building terminated because of errors.

C:\libjingle\trunk\talk>

=====================================

If I change "projects" to "project", it gives success output:

C:\libjingle\trunk\talk>c:\swtoolkit\hammer.bat --mode=all --vsproj
scons: Reading SConscript files ...

scons: warning: The build_dir keyword has been deprecated; use the variant_dir k
eyword instead.
File "c:\swtoolkit\site_scons\site_init.py", line 203, in BuildEnvironmentSConsc
ripts

scons: warning: The build_dir keyword has been deprecated; use the variant_dir k
eyword instead.
File "c:\swtoolkit\site_scons\site_init.py", line 203, in BuildEnvironmentSConsc
ripts

scons: warning: The build_dir keyword has been deprecated; use the variant_dir k
eyword instead.
File "c:\swtoolkit\site_scons\site_init.py", line 203, in BuildEnvironmentSConsc
ripts
***Unfortunately the vsproj creator isn't smart enough to
***automatically get the correct output locations.  It is very easy
***though to change it in the properties pane to the following
***($SolutionDir)/build/<foo>/staging/<bar>.exe
scons: done reading SConscript files.
scons: Building targets ...
ComponentVSSolutionBuilder(["build\solution\libjingle.sln"], [])
ComponentVSProjectBuilder(["build\solution\projects\relayserver.vcproj"], [])
ComponentVSProjectBuilder(["build\solution\projects\libxmpphelp.vcproj"], [])
ComponentVSProjectBuilder(["build\solution\projects\stunserver.vcproj"], [])
ComponentVSProjectBuilder(["build\solution\projects\libsrtp.vcproj"], [])
ComponentVSProjectBuilder(["build\solution\projects\expat.vcproj"], [])
ComponentVSProjectBuilder(["build\solution\projects\libjingle.vcproj"], [])
ComponentVSProjectBuilder(["build\solution\projects\call.vcproj"], [])
ComponentVSProjectBuilder(["build\solution\projects\login.vcproj"], [])
scons: done building targets.

C:\libjingle\trunk\talk>

Original comment by studentt...@gmail.com on 28 May 2011 at 1:44

[GoogleCodeExporter]

Thanks for reporting this error. There is actually another issue in the 
main.scons file. The fix will be available in the next release (0.5.6). 
Meanwhile, you can just remove the following line to make it work.
Line 485:  '$THIRD_PARTY'
and add the "]," to line 484.

Original comment by jun...@google.com on 1 Jun 2011 at 11:23