Closed PowerKiKi closed 8 years ago
Hey @weierophinney I created this PR a while ago but didn't get any kind of feedback yet. Would you please let me know if I missed something important from the contributions guidelines ?
@PowerKiKi Sorry for the delay in reviewing this! We were busy with getting ZF3 released, and are now about ready to release an Apigility version compatible with it. I'm reviewing today, and we should see it live on the website soon.
Thanks for the great recipe!
@PowerKiKi I'm editing this locally, and have a few concerns:
AbstractRepository
(does this refer to Doctrine\ORM\EntityRepository
? or something else?)AbstractModel
(no idea)example.org
domains in URIs.getServiceLocator()
is deprecated in zend-mvc v2, and removed entirely in zend-mvc v3; please add a factory for the controller that injects the dependencies it needs. From what I can see, this includes the config
(note: lowercased!) service's hybridauth
key as an array of configuration, the config
service's cryptoKey
value as a string, and the Doctrine\ORM\EntityManager
.::class
notation wherever possible, or the imported name.Once the above issues are resolved, I can review again for merge.
Thanks again!
I am gonna be honest, I had lost all hope of this PR being merged. So while I am inclined to do a few modifications as highlighted by @weierophinney, I will ignore the more involved one by @jguittard (such as "moving lots of business code into a dedicated service/model layer"). If you feel it is not enough, then better close this PR right away.
So I made the modifications as asked for. Except that JavaScript functions must both be available in window
, so they cannot be wrapped in a self calling function.
@weierophinney could you please have a look again ?
@weierophinney, I just allowed maintainers to edit this PR so we can better collaborate and finally merge it. Could you please have a look at it ?
Thanks, @PowerKiKi; this is a great addition to the manual!
I'm glad it's appreciated, and thank you for finding the time to merge this!
This recipes describe how to integrate social logins from Facebook, Google and others, into Apigility authentification process