zfcampus / apigility-documentation

Documentation for the Apigility project.
BSD 3-Clause "New" or "Revised" License
22 stars 37 forks source link

Add a recipe to integrate social logins #62

Closed PowerKiKi closed 8 years ago

PowerKiKi commented 9 years ago

This recipes describe how to integrate social logins from Facebook, Google and others, into Apigility authentification process

PowerKiKi commented 9 years ago

Hey @weierophinney I created this PR a while ago but didn't get any kind of feedback yet. Would you please let me know if I missed something important from the contributions guidelines ?

weierophinney commented 8 years ago

@PowerKiKi Sorry for the delay in reviewing this! We were busy with getting ZF3 released, and are now about ready to release an Apigility version compatible with it. I'm reviewing today, and we should see it live on the website soon.

Thanks for the great recipe!

weierophinney commented 8 years ago

@PowerKiKi I'm editing this locally, and have a few concerns:

Once the above issues are resolved, I can review again for merge.

Thanks again!

PowerKiKi commented 8 years ago

I am gonna be honest, I had lost all hope of this PR being merged. So while I am inclined to do a few modifications as highlighted by @weierophinney, I will ignore the more involved one by @jguittard (such as "moving lots of business code into a dedicated service/model layer"). If you feel it is not enough, then better close this PR right away.

PowerKiKi commented 8 years ago

So I made the modifications as asked for. Except that JavaScript functions must both be available in window, so they cannot be wrapped in a self calling function.

@weierophinney could you please have a look again ?

PowerKiKi commented 8 years ago

@weierophinney, I just allowed maintainers to edit this PR so we can better collaborate and finally merge it. Could you please have a look at it ?

weierophinney commented 8 years ago

Thanks, @PowerKiKi; this is a great addition to the manual!

PowerKiKi commented 8 years ago

I'm glad it's appreciated, and thank you for finding the time to merge this!