search

zfcampus / zf-apigility-admin

Admin API and UI for Apigility
BSD 3-Clause "New" or "Revised" License
90 stars 64 forks source link

Make module version dynamic #373

Closed robertmarsal closed 6 years ago

robertmarsal commented 7 years ago

Hello,

I am currently using the zf-apigility-admin classes to create an Apigility skeleton programmatically with this project https://github.com/robertboloc/raml2apigility.

What I noticed, is that createModule creates the initial directories on version 1 and that value can't be changed on invocation. In real life usages there might already be an existing API and a new version is being worked on with Apigility, so ideally we should be able to create an API starting from a +1 version.

This PR allows to specify the initial version when creating the module, defaulting to 1.

If the PR is accepted a similar one should probably be created for the UI project to allow defining this initial version on creation.

Thank you.

Regards, Rob

weierophinney commented 6 years ago

Thanks, @robertboloc! Merged, and will release shortly with 1.6.0. Go ahead and create a PR against the UI module, and we can do a release of that when it is ready.