zfcampus / zf-apigility-admin

Admin API and UI for Apigility
BSD 3-Clause "New" or "Revised" License
90 stars 64 forks source link

zfcampus/zf-configuration 1.3.1 - breaks apigility admin #378

Closed michalbundyra closed 6 years ago

michalbundyra commented 6 years ago

As noted in https://github.com/zfcampus/zf-configuration/issues/28 seems that zfcampus/zf-configuration 1.3.1 break Apigility admin.

This PR should prove this - I've updated composer.lock to zf-configuration 1.3.0 so tests will run with the following version of zf-configuration:

The change which break Apigility admin at this point was made be me in https://github.com/zfcampus/zf-configuration/pull/25

I think the behaviour of zf-configuration was wrong, the method was not tested and documented, but unfortunately this wrong behaviour has been used in other components. The simplest solution will be revert change introduced in zf-configuration 1.3.1 and fix it in 2.0.0.

See also: https://github.com/zfcampus/zf-apigility-doctrine/issues/295 https://github.com/zfcampus/zf-apigility-doctrine/pull/296 https://github.com/zfcampus/zf-configuration/issues/21

/cc @weierophinney @samsonasik @developer-devPHP

weierophinney commented 6 years ago

This needs to be updated to prevent usage of the 1.3.1 version within the composer.json:

"zfcampus/zf-configuration": ">=1.2.1, <1.3.1, >1.3.1, <2.0"

This will ensure that 1.3.1, the current latest version, will never be installed.

weierophinney commented 6 years ago

Thanks, @webimpress. I have added the appropriate constraint, and ensured tests pass at this time.