search

zfcampus / zf-apigility-admin

Admin API and UI for Apigility
BSD 3-Clause "New" or "Revised" License
90 stars 64 forks source link

Fix for creating new REST services #381

Closed wshafer closed 6 years ago

wshafer commented 6 years ago

On new installs or after updating composer, creating new Rest services fail with the error: 

Fatal error: Declaration of ZF\Apigility\Admin\InputFilter\RestService\PostInputFilter::isValid() must be compatible with Zend\InputFilter\BaseInputFilter::isValid($context = NULL) in /var/www/vendor/zfcampus/zf-apigility-admin/src/InputFilter/RestService/PostInputFilter.php on line 12

This patch simply adds the new signature so the Rest service can be built.

weierophinney commented 6 years ago

Can you tell me which version of zend-inputfilter raises the issue for you? And on what version of PHP you observe it?

weierophinney commented 6 years ago

Actually, never mind. We have the lowest/locked/latest strategy configured for our Travis builds on this component, and they demonstrate clearly that your change works fine across each PHP version tested, as well as a range of zend-inputfilter versions ranging from 2.7.2 to 2.8.0. As such, the fix will clearly work for all installs.

Thanks, @wshafer !