zfcampus / zf-apigility-admin

Admin API and UI for Apigility
BSD 3-Clause "New" or "Revised" License
90 stars 64 forks source link

Issue with PHP 7.2 #389

Closed ezimuel closed 6 years ago

ezimuel commented 6 years ago

Using PHP 7.2 I noticed an issue creating a new REST service using the Apigility UI. The error is as follows:

PHP Fatal error: Declaration of ZF\Apigility\Admin\InputFilter\RestService\PostInputFilter::isValid() must be compatible with Zend\InputFilter\BaseInputFilter::isValid($context = NULL) in /folder/apigility/vendor/zfcampus/zf-apigility-admin/src/InputFilter/RestService/PostInputFilter.php on line 12

michalbundyra commented 6 years ago

Also:

Declaration of ZF\Apigility\Admin\InputFilter\InputFilterInputFilter::isValid() must be compatible with Zend\InputFilter\BaseInputFilter::isValid($context = NULL) in ...

Edit: actually it has been fixed in #382. I was using outdated version.

michalbundyra commented 6 years ago

@ezimuel I think you are also using outdated version of zf-apigility-admin :)

It has been fixed in #381 and #382 and released with 1.5.13

ezimuel commented 6 years ago

@webimpress ok, we need to update zf-apigility-skeleton because the Apigility installation process install zf-apigility-admin 1.5.9.

michalbundyra commented 6 years ago

@ezimuel I've created PR https://github.com/zfcampus/zf-apigility-skeleton/pull/162

michalbundyra commented 6 years ago

@ezimuel It can be now closed as Apigility 1.4.2 is released.