search

zfcampus / zf-console

Create console applications in PHP
BSD 3-Clause "New" or "Revised" License
64 stars 25 forks source link

Adding the ability to remove a route #18

Closed ArnaudLigny closed 9 years ago

ArnaudLigny commented 9 years ago

Fixing #17

ArnaudLigny commented 9 years ago

Ping @weierophinney :-)

ArnaudLigny commented 9 years ago

Have I any chance to have a review of my proposition ? :-)

Thank you!

RalfEggert commented 9 years ago

+1

weierophinney commented 9 years ago

Why would you need it, @Narno ?

I ask, because you typically create your application iteratively; it's not something you extend. If you need to remove a route, then why did you add it in the first place?

Essentially, I want to understand the use case before merging.

RalfEggert commented 9 years ago

@weierophinney This is mainly about removing the default routes autocomplete, help and version. They are added in ZF\Console\Application::__construct() with every run if you need them or not.

ArnaudLigny commented 9 years ago

Hello @weierophinney, as indicated by @RalfEggert, the goal is to remove the default routes and also to manage a plugin logic and so be able to remove and replace a route with another.

weierophinney commented 9 years ago

@Narno and @RalfEggert — thanks for the clarification!

ArnaudLigny commented 9 years ago

Thanks a lot!