search

zfcampus / zf-doctrine-querybuilder

Doctrine Query Builder request Filters
BSD 3-Clause "New" or "Revised" License
32 stars 19 forks source link

Use protected methods in Query Providers #38

Closed TomHAnderson closed 6 years ago

TomHAnderson commented 7 years ago

When the DefaultOrm Query Provider is extended and the default createQuery function is not called, instead opting to run the filters directly, the functions to fetch the managers are private and cannot be accessed.

This PR changes any private functions on Query Providers to public.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 86.287% when pulling da691f7d9e19e071592e506aa2d36aa3b8b1c166 on TomHAnderson:hotfix/query-provider-scope into c5c483e512020d2964e267b219a67aa4ff41f069 on zfcampus:master.

TomHAnderson commented 7 years ago

This is not a BC but getting this approved during these holidays would be nice.

TomHAnderson commented 7 years ago

This approved PR is nearly 6 months old! Is someone assigned to maintain this repository at zfcampus? cc @webimpress @weierophinney

michalbundyra commented 7 years ago

@weierophinney What do you think? Can we release it safely as 1.5.2? Methods visibility is changed, for me it is not BC Break, because it will be the same if we add new protected methods.

michalbundyra commented 6 years ago

@TomHAnderson thanks !