fix filtering of joined/referenced fields, add custom types support

zfcampus / zf-doctrine-querybuilder

Doctrine Query Builder request Filters

BSD 3-Clause "New" or "Revised" License

32 stars 19 forks source link

fix filtering of joined/referenced fields, add custom types support #48

Closed gegok closed 5 years ago

gegok commented 6 years ago

1) typeCastField() is not used correctly for reference fields and joined entity fields because of wrong $metadata object usage

2) filters doesn't support custom data types added $fieldType passing to setParameter();

coveralls commented 6 years ago

Coverage decreased (-1.8%) to 83.57% when pulling 6e6c375fcc89dd8b8da6ae2912417bbfea75fb93 on gegok:tsp-fix-filters into e1a286851b0a7122e94c06b2dba74febeb795122 on zfcampus:master.

michalbundyra commented 6 years ago

@gegok We need tests to cover these changes and demonstrate the described issues.

weierophinney commented 5 years ago

Closing, due to lack of tests.