search

zfit / phasespace

Phase space generation implemented in TensorFlow
https://phasespace.rtfd.io
BSD 3-Clause "New" or "Revised" License
24 stars 9 forks source link

Release version mixup #30

Closed mdoucet closed 5 years ago

mdoucet commented 5 years ago

Reviewing this for JOSS, I found that installing from the source code and installing with pip install phasespace produced different versions of the code, both with version number 1.0.2.

Installing from pip gives me an older version of the code with the deprecated phasespace.Particle class instead of phasespace.GenParticle.

apuignav commented 5 years ago

@mayou36 do you know what may have happened?

jonas-eschle commented 5 years ago

Yes, we usually kept the version on the development branch unchanged to the previous release and did not mark dev versions explicitly. I've added a 'dev0' to clarify the difference, so installing from the HEAD now yields a different version.

Out of interest: why did you install directly from github dev branch? I think for the review, the release is relevant, right?

mdoucet commented 5 years ago

Thanks for the info. I started out with the release version 1.0.2, and started following the documentation in your README.rst file (which we see when landing on your github project page). It seemed to make sense since it appeared to also be for version 1.0.2. When I started having problems I installed from the source code to investigate. I understand now, though. The phasespace.readthedocs.io page for 1.0.2 is also correct. You might want to label your version in the README.rst file, especially if there's a major API change.