search

zfit / phasespace

Phase space generation implemented in TensorFlow
https://phasespace.rtfd.io
BSD 3-Clause "New" or "Revised" License
24 stars 9 forks source link

Enhance setup and pre-commit #42

Closed jonas-eschle closed 3 years ago

redeboer commented 3 years ago

Maybe it's better to split up this PR (formatting, improvements to the CI, updating the setup files, and refactoring function decorators)? Then it's easier to review the refactoring work :)

jonas-eschle commented 3 years ago

Thanks, that's a good point indeed, and the decorator I put in another branch as it is independent.

Most of the changes are automatic reformatting though, which just comes from the pre-commit. We could have put that separately, indeed. The rest is though intertwined: setup and CI basically.

I would suggest to go ahead, okay? the changes are actually minor and not really relevant, just dev stuff basically, but I'll gladly ping you in the future again for reviews, that would be quite helpful, many thanks!

redeboer commented 3 years ago

Sure, just a comment while trying to make sense of the changes ;) I'm also more used to squash merging, where it's more important to keep the PRs small, but with merges this doesn't really matter.