redeboer commented 2 years ago

Note that Python 3.10 is not yet supported: https://discuss.tensorflow.org/t/support-python-3-10/124

redeboer commented 2 years ago

Motivation: TF 2.7 supports typing-extensions==3.10, which many newer versions of packages like black and pylint require. https://github.com/ComPWA/tensorwaves/runs/3996801941?check_suite_focus=true#step:9:9

jonas-eschle commented 2 years ago

Great, makes sense. I think we can still leave 2.5 and 2.6 as valid versions (as you've done it), there is no breaking feature in 2.7 afai can see

codecov-commenter commented 2 years ago

Codecov Report

Merging #66 (ca7102f) into master (61e38f8) will decrease coverage by 0.28%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   91.30%   91.01%   -0.29%     
==========================================
  Files           5        5              
  Lines         345      345              
  Branches       62       62              
==========================================
- Hits          315      314       -1     
- Misses         19       20       +1     
  Partials       11       11

Impacted Files	Coverage Δ
phasespace/phasespace.py	`89.23% <0.00%> (-0.39%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61e38f8...ca7102f. Read the comment docs.

redeboer commented 2 years ago

Do you know why RTD fails? https://readthedocs.org/projects/phasespace/builds/15190786

jonas-eschle commented 2 years ago

I have no idea... that looks really weird. As it is not related seemingly to this PR, we can also merge. I made an issue for it

redeboer commented 2 years ago

Thanks! Could you make a new release?

zfit / phasespace

build: support TF 2.7 #66

Codecov Report