freebsd: recent changes for O_EXEC implementation

zfsonfreebsd / ZoF

ZFS on FreeBSD - the official out of tree OpenZFS implementation for FreeBSD

https://freebsd.org

Other

100 stars 8 forks source link

freebsd: recent changes for O_EXEC implementation #152

Closed kevans91 closed 4 years ago

kevans91 commented 4 years ago

This includes a light refactoring to make sure that we're not duplicating the check for VEXEC rights when it's already done in vfs_cache_lookup, then honoring NOEXECCHECK if we're in a tree where it's defined.

Note that the openzfs-kmod port is still BROKEN- it needs some kind of autoconf dance to get zfs_config.h generated, and VOP_MARKATIME is now spelled VOP_MMAPPED (mjg r357361)

kevans91 commented 4 years ago

I guess I should have mentioned- this is both compile-time and runtime compatible with 12.x- only the #ifdef NOEXECCHECK was needed for compatibility.

ghost commented 4 years ago

Thanks Kyle. Can you update the target branch of the PR to projects/pr-rebase-20200205 please and I will merge. I will ask someone to bump the ports once merged.

kevans91 commented 4 years ago

Hmmm... I'll rebase this properly tomorrow- not about to try and resolve the merge conflicts via their interface.

ghost commented 4 years ago

I'll just cherry-pick your commit, no worries.

ghost commented 4 years ago

d3f3189

kevans91 commented 4 years ago

Oh, perfect, thanks!