Restore aclmode property for FreeBSD

zfsonfreebsd / ZoF

ZFS on FreeBSD - the official out of tree OpenZFS implementation for FreeBSD

https://freebsd.org

Other

100 stars 8 forks source link

Restore aclmode property for FreeBSD #85

Closed ghost closed 5 years ago

ghost commented 5 years ago

FreeBSD uses NFSv4 ACLs and has an aclmode property to control the behavior of chmod(2).

The acltype property from ZoL is a separate thing. We probably want a new value to indicate NFSv4 ACLs on FreeBSD. It should not control the ACL mode.

Issue: #56

ghost commented 5 years ago

This PR addresses the second part I described in the issue, but I think there is still an issue with the first part. The acltype property currently does nothing on FreeBSD, but it should perhaps "control whether ACLs are enabled and if so what type of ACL to use".

I have started looking closer into the history of ACLs in ZoL and now I understand a little better that they did not entirely rip out the NFSv4 ACLs from ZFS, only from the VFS layer.