aktau
commented
8 years ago I noticed the same thing happening. The logic for choosing a "compatible" version of spl-dkms can be found in /var/lib/dkms/zfs/0.6.5.2/build/dkms.conf (gist of my local version).
The relevant part is this:
--with-spl=${source_tree}/spl-$(subver=`echo ${PACKAGE_VERSION} | sed "s@\([0-9]\.[0-9]\.[0-9]\)\(\.[0-9]\)@\1@"`
if [ -e ${source_tree}/spl-${PACKAGE_VERSION} ]; then
echo ${PACKAGE_VERSION}
elif [ -e ${source_tree}/spl-${subver} ]; then
echo ${subver}
fi)
--with-spl-obj=${dkms_tree}/spl/$(subver=`echo ${PACKAGE_VERSION} | sed "s@\([0-9]\.[0-9]\.[0-9]\)\(\.[0-9]\)@\1@"`
if [ -e ${source_tree}/spl-${PACKAGE_VERSION} ]; then
echo ${PACKAGE_VERSION}
elif [ -e ${source_tree}/spl-${subver} ]; then
echo ${subver}
fi)/${kernelver}/${arch}Naturally, this code on my system yields the following value:
BAD spl: /usr/src/spl-
BAD spl-obj: /var/lib/dkms/spl//4.2.0-1-amd64/x86_64On which the build process chokes.
As can be seen, it tries to find either the same PACKAGE_VERSION of dkms-spl as the dkms-zfs it is trying to build, in this case 0.6.5.2. Failing that, it tries to find dkms-spl-0.6.5 (that's the subver). Which is also not installed on my system.
It seems to me line spl and zol are using semantic versioning, which means that the latest in the same minor version bracket 0.6.5.* should work for any zfs 0.6.5.*. So the situation for Debian Stretch and possibly ubuntu could be improved with something like this:
spl_new=${source_tree}/spl-$(
subver=$(echo ${PACKAGE_VERSION} | sed "s@\([0-9]\.[0-9]\.[0-9]\)\(\.[0-9]\)@\1@")
subver_max=$(cd ${source_tree}; for max in spl-${subver}.?; do :; done; echo "${max#spl-}")
if [ -e ${source_tree}/spl-${PACKAGE_VERSION} ]; then
echo ${PACKAGE_VERSION}
elif [ -e ${source_tree}/spl-${subver} ]; then
echo ${subver}
elif [ -e ${source_tree}/spl-${subver_max} ]; then
echo ${subver_max}
fi)
spl_obj_new=${dkms_tree}/spl/$(
subver=`echo ${PACKAGE_VERSION} | sed "s@\([0-9]\.[0-9]\.[0-9]\)\(\.[0-9]\)@\1@"`
subver_max=$(cd ${source_tree}; for max in spl-${subver}.?; do :; done; echo "${max#spl-}")
if [ -e ${source_tree}/spl-${PACKAGE_VERSION} ]; then
echo ${PACKAGE_VERSION}
elif [ -e ${source_tree}/spl-${subver} ]; then
echo ${subver}
elif [ -e ${source_tree}/spl-${subver_max} ]; then
echo ${subver_max}
fi)/${kernelver}/${arch}Which yields
NEW spl: /usr/src/spl-0.6.5.3
NEW spl-obj: /var/lib/dkms/spl/0.6.5.3/4.2.0-1-amd64/x86_64Which is better, IMHO.
The salient part is the subver_max, which finds the maximum version dkms-spl inside of the same semantic minor version.
@FransUrbo what do you think?
roeme
mailinglists35
Baughn
FransUrbo
Hi,
after upgrading my system's kernel from 4.2.3 to 4.2.5, to ZFS module was no longer loaded (mismatching symbols). Trying to rebuild the modules yielded strange errors:
(Note the missing version number for the spl source directory). The
spl-dkmsmodule was sucessfully installed, however.Further investigation reveals a version mismatch of the interesting sort:
So
spl-dkmshas hit the official servers with 0.6.5.3 (at least in debian'stesting), but remains at 0.6.5-1 on zfsonlinux’ own repo.Downgrading
spl-dkmsto 0.6.5-1 fixes the issue, and allows one to build/load version 0.6.5.2 ofzfs-dkms.