zgauthier8286 / git-repo

Automatically exported from code.google.com/p/git-repo
Apache License 2.0
0 stars 0 forks source link

repo init -m foobar.xml fails if .repo/manifest.xml exists and is broken (pointing at a missing file) #129

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Affected Version: git master (0290cad5db0eef3b15eb976dd7a017837e36c8b7)
Environment: Linux

What steps will reproduce the problem?
1. Create a manifests repository with a.xml and b.xml
2. Run repo init a.xml
3. Delete a.xml from upstream manifests repository
4. Run repo sync
5. Run repo init -m b.xml

What is the expected output?
repo switches to b.xml

What do you see instead?
repo errors while updating the manifest.xml symlink

Please provide any additional information below.
This is caused by the symlink being broken and repo using os.path.exists 
instead of os.path.lexists to check for existance before removing the old 
symlink.

See attached patch for a fix.

Original issue reported on code.google.com by webust...@gmail.com on 15 Jan 2013 at 4:11

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by david.pu...@sonymobile.com on 1 Feb 2013 at 2:06