DbDeploy generates invalid SQL for Oracle 9 and 10

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create DDL or DML deltas
2. Generate output SQL for Oracle (dbms=ora)
3. See "BEGIN TRANSACTION;" in output.sql

What is the expected output? What do you see instead?
Oracle automaticly starts transactions thus expected no statements for
begining transactions.

What version of the product are you using? On what operating system?
Oracle 9, Oracle 10.

Please provide any additional information below.

"BEGIN TRANSACTION;" statement is invalid for Oracle.

Fix:
In com.dbdeploy.database.syntax.OracleDbmsSyntax.java add 
public String generateBeginTransaction() {
                return "";
        }

Same for OracleSqlPlusDbmsSyntax.java

Original issue reported on code.google.com by anem...@gmail.com on 22 May 2009 at 9:03

[GoogleCodeExporter]

git://github.com/betarelease/dbdeploy.git

This issue is fixed in commit key (version) 
813775e9b84cf7c8e233dfa3aeddda95833d1998

at the above URL.

Original comment by srra...@gmail.com on 28 May 2009 at 5:11

[GoogleCodeExporter]

That was a silly mistake on my behalf, especially since oracle is the db I use 
every
day in my day job....

Thanks for spotting this, and thanks for your help in fixing.

Fixed in r102

Original comment by gtack...@googlemail.com on 31 May 2009 at 11:35

• Changed state: Done
• Added labels: Milestone-Release3.0, Priority-Critical
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Issue 25 has been merged into this issue.

Original comment by gtack...@googlemail.com on 14 Sep 2009 at 2:17