search

zgimbutas / mwrap

Matlab MEX gateway generator
Other
9 stars 8 forks source link

adding underscore0 option for windows libmwblas mingw support #11

Closed mrachh closed 2 years ago

mrachh commented 2 years ago

Added an option for underscore0, tested it on the FMM3D library on Mac and windows

ahbarnett commented 2 years ago

@zgimbutas are you going to resolve this and pull in? I will also make a PR in the README, simple one. Happy summer, Alex

zgimbutas commented 2 years ago

Alex,

I’ve already merged this change into mwrap. I had to make some extra changes, so was a bit more than the pull request. I also updated the README file.

Please take a look if everything is ok. If you need to make additional changes, the right way would be to close #11 and open a new pull request.

Have a nice end of the summer as well!

Best, Zydrunas

On Aug 26, 2022, at 6:27 PM, Alex Barnett @.***> wrote:

@zgimbutas https://github.com/zgimbutas are you going to resolve this and pull in? I will also make a PR in the README, simple one. Happy summer, Alex

— Reply to this email directly, view it on GitHub https://github.com/zgimbutas/mwrap/pull/11#issuecomment-1228696355, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWJ3GUT54K62K6DPFRAX6TV3DV6XANCNFSM5YEBYACQ. You are receiving this because you were mentioned.

ahbarnett commented 2 years ago

Closing then (the traditional way if dealt with another way...)