search

zgimbutas / mwrap

Matlab MEX gateway generator
Other
9 stars 8 forks source link

Unit testing failure with Bison 3.6.3 #7

Closed rlaboiss closed 4 years ago

rlaboiss commented 4 years ago

Running the unit testing of mwrap fails against Bison 3.6.3, with the following error message:

(cd testing; make)
[…]
mkoctfile --mex test_c99_complexmex.c
../mwrap -cppcomplex test_syntax.mw 2> test_syntax.log
make[1]: [Makefile:33: test_syntax] Error 1 (ignored)
diff test_syntax.log test_syntax.ref
2c2
< Parse error (test_syntax.mw:8): syntax error, unexpected end of file, expecting ';'
---
> Parse error (test_syntax.mw:8): syntax error, unexpected $end, expecting ';'

This commit fixes the problem.

zgimbutas commented 4 years ago

Unfortunately, this breaks old versions of Bison. Should we simply disable the error checking in Makefile by adding a minus sign?

 - diff test_syntax.log test_syntax.ref
rlaboiss commented 4 years ago

Unfortunately, this breaks old versions of Bison. Should we simply disable the error checking in Makefile by adding a minus sign?

 - diff test_syntax.log test_syntax.ref

Yes, this might be a good idea.

zgimbutas commented 4 years ago

Fixed in master branch