Something to add to the readme

ivorpad commented 5 years ago

According to package.json the site should be started with yarn workspace site develop instead of yarn workspace starter develop
If someone wants to use this Gatsby theme with their own WordPress instance, then they need to change the menu location here Menu.js#L19 to one of the locations registered by WordPress to prevent a compilation error when running yarn workspace site develop

register_nav_menus(
  array(
    'menu-1' => __( 'Primary', 'twentynineteen' ),
    'footer' => __( 'Footer Menu', 'twentynineteen' ),
    'social' => __( 'Social Links Menu', 'twentynineteen' ),
  )
);

Locations available here: MENU_1, FOOTER, SOCIAL

Great work folks! I'll keep using it and report any issues if there's any.

boborchard commented 5 years ago

@ivorpad I just found the same issue when testing the theme today with the workspace name and opened a PR to fix it at https://github.com/zgordon/tabor-gatsby-theme/pull/11.

shanebp commented 5 years ago

@ivorpad Thanks for listing those 2 items and the solutions. Much Appreciated.

zgordon / tabor-gatsby-theme

Something to add to the readme #10