search

zgrossbart / jdd

A semantic JSON compare tool
http://www.jsondiff.com
Apache License 2.0
1.05k stars 183 forks source link

Clear Button for JSON input #2

Open p-shah opened 7 years ago

p-shah commented 7 years ago

Awesome service but there's no button to clear the input.

zgrossbart commented 7 years ago

Thank you for the comment. You can press the "Perform a new diff" button, remove the input manually, or refresh the page. What kind of button are you looking for?

p-shah commented 7 years ago

Just to have the option to not have to manually each time. But if it was designed purposely that way, my bad.

zgrossbart commented 7 years ago

No need for a mea culpa. I'm really curious what you mean. Were you looking for a clear button while you were using the page? When did you want it? I want to make this as usable as possible. Thank you for the help.

p-shah commented 7 years ago

Yeah I was just using JSON diff service and noticed everytime I tried to perform a new diff I had to manually clear the input on each side. I figured to a button clear above each of the inputs would be useful. Thanks for the service.. Super helpful.

zgrossbart commented 7 years ago

That makes sense. I was torn about that feature. Right now I don't clear the inputs when you perform a new diff based on the idea that you might want to change the existing input rather than have something totally new. What do you think? Does it make sense to clear the input there?

I'm also trying to keep everything really simple and not add more buttons that an absolutely have to.

saurabheights commented 7 years ago

@zgrossbart : My two cents here: Although, I am wary of this functionality as well, however a warning message box regarding "Do you want to really clear all data?" should be sufficient. Clearing the input manually is more effort than the two clicks, one for the clear button and one for the confirm.

One more thought in keeping the ui simple - you can keep all advanced options at the bottom and initially hidden. When user selects the advanced options button, then the panel of all options appears. For naive user's, this should suffice. For intermediate/advanced users, having a right taxonomy of the options in the panel would further simplify the use of this options. Adding an information("i") button to these options would even be better.