search

zgrossbart / jdd

A semantic JSON compare tool
http://www.jsondiff.com
Apache License 2.0
1.03k stars 180 forks source link

Updated styles #28

Closed fmalina closed 5 years ago

fmalina commented 5 years ago

Fixes #26

zgrossbart commented 5 years ago

Thank you so much for this update. I think the new colors work really well on the compare page. If you can make the text in the upper right of the main page align with the right-side compare field then I'd be really happy to take in this change.

Screen Shot 2019-03-25 at 8 42 01 AM
zgrossbart commented 5 years ago

I have a couple of small spacing tweaks: https://github.com/zgrossbart/jdd/pull/29

fmalina commented 5 years ago

Looks great!

zgrossbart commented 5 years ago

Sounds good. Would you like to merge my PR into yours, or would you like me to merge your PR and then make changes on top of it?

fmalina commented 5 years ago

I don't have a preference. But I'd love if you could make this live and look at #27

zgrossbart commented 5 years ago

I have merged it in and made my changes on top of it. Let me do a little more testing and I'll get it deployed soon.

I need to look more at #27. I'm not sure about how that will work for larger JSON documents. Let me think about it a bit more.

zgrossbart commented 5 years ago

This change is now deployed. Thanks again for the awesome update.