search

zgrossbart / jdd

A semantic JSON compare tool
http://www.jsondiff.com
Apache License 2.0
1.05k stars 183 forks source link

Exposed as a function so that multiple instances of it can be created wi… #31

Closed nitinsurana closed 5 years ago

nitinsurana commented 5 years ago

…th a different parent and do not interfere with each others' calcuation.

It also allows to re-initialize the UI with new dataset without refreshing the page All qunit tests are working fine. Fixes #30

zgrossbart commented 5 years ago

Thank you for this. I'll take a closer look tomorrow.

Do you think this should get merged into the master branch for the jsondiff.com website, or stay a separate project?

nitinsurana commented 5 years ago

It's a lot of change :-| I'm not sure, whether we should merge it or not. It's a call you'd have to take.

As far as functionality is concerned, jsondiff.com would remain unaffected with these changes. It may just become easier for someone to quickly inject this into their app.

nitinsurana commented 5 years ago

After giving it another thought - there's still a lot of coupling between UI and diffModel. Let's not merge at this point. Thanks for this nice project.

zgrossbart commented 5 years ago

I agree. I'm going to close this PR. Thank you.