Highlight children when parent is missing

zgrossbart / jdd

A semantic JSON compare tool

http://www.jsondiff.com

Apache License 2.0

1.05k stars 183 forks source link

Highlight children when parent is missing #36

Closed SvenWerlen closed 4 years ago

SvenWerlen commented 4 years ago

I used your script in one of my project. I improved it by also highlighting children when a parent was missing.

See the differences between the original

And the new version

Feel free to accept it or reject it if it doesn't fit your purpose

SvenWerlen commented 4 years ago

I found a few bugs to be fixed

zgrossbart commented 4 years ago

Thank you for working on this contribution to JSONDiff. If you'd like to try again I'd ben interested to take a look. Can you please tell me more about what this change was trying to do?

SvenWerlen commented 4 years ago

Thanks. I'll resubmit a pull request later today that fixes the issues I found. I did 2 changes:

When a parent is missing (left or right), all its children will also be highlighted. This is common behavior in diff tools. You can see it in the above screenshots
I refactored a little bit the jdd.js such it can be reused as library (I externalized the html dependent parts)

By the way, many thanks for this excellent project. I saved hours in reusing it!