search

zgrossbart / jdd

A semantic JSON compare tool
http://www.jsondiff.com
Apache License 2.0
1.03k stars 180 forks source link

Removal of jQuery from jdd #56

Closed gangadharjannu closed 1 year ago

gangadharjannu commented 1 year ago

Hello @zgrossbart

I use jdd regularly and would like to know your opinion on removal of jQuery.

I am happy to work on PR if you are okay.

zgrossbart commented 1 year ago

Thank you @gangadharjannu. I'm glad that JSONDiff is working well for you. Can you please tell me more about why you want to remove jQuery.

gangadharjannu commented 1 year ago

There are multiple reasons,

  1. If we remove jQuery jdd will be pure JavaScript solution and it is easier for others to port this to other JavaScript frameworks like Angular or React (if they want).
  2. Less size https://bundlephobia.com/package/jquery@3.7.0
  3. Also no need to update frequently since there is no maintenance required for library update due to version changes or securities.
  4. I'm sure there will be performance improvements as the proposed solution would be native to browser.
  5. Browsers are more mature now and most of the DOM manipulation can be implement with pure JavaScript easily.

Let me know your thoughts/suggestions

zgrossbart commented 1 year ago

You make a very compelling argument @gangadharjannu. I'd be happy to see a PR on this. Please make sure that we still pass all unit tests. I'm also happy to work on the PR with you.

gangadharjannu commented 1 year ago

Sure, Thanks for your understanding, I already started working on the PR, I will raise the PR once it is ready.

Yes, I'm checking unit tests :)

gangadharjannu commented 1 year ago

@zgrossbart Here is the PR https://github.com/zgrossbart/jdd/pull/57.

All the functionality is converted to pure JavaScript.

Let us discuss remaining things in the PR

zgrossbart commented 1 year ago

57 is merged and this issue is resolved.