search

zgrossbart / jdd

A semantic JSON compare tool
http://www.jsondiff.com
Apache License 2.0
1.05k stars 183 forks source link

Fix JSON Data Comparison Functionality #69

Closed jaykradadiya closed 6 months ago

jaykradadiya commented 6 months ago

This update addresses an issue where incorrect JSON format in the textbox caused errors for the user, preventing them from re-comparing data after correction. With this fix, users can now rectify JSON format errors and subsequently compare data without encountering obstacles.

zgrossbart commented 6 months ago

Thank you for the PR @jaykradadiya. Do you have a set of steps I can use to reproduce this issue? I'd like to verify the fix and add this case to the test suite if that makes sense.

jaykradadiya commented 6 months ago

To reproduce the issue:

  1. Enter invalid JSON data in the input box.
  2. Click on the submit button.
  3. Upon receiving the error message indicating an invalid JSON format, correct the JSON data.
  4. Attempt to click on the submit button again.

At step 4, the submit button remains disabled, preventing the comparison of JSON data even after correction.

zgrossbart commented 6 months ago

Thank you for the description @jaykradadiya. Those steps were clear and easy to follow.

And a big thank you for the PR. I'm going to merge this.