zhaar / Hackerspaces-iOS

Repository of the Hackerspaces iOS app
MIT License
2 stars 1 forks source link

Site shows unresponsive though it can be reached via a web browser #10

Open pjz opened 5 years ago

pjz commented 5 years ago

Nova Labs's api URL is http://nova-labs.org/api/ and is clearly reachable, but the app lists it as 'unresponsive' so it can't be selected. Any ideas?

andrevidela commented 5 years ago

I have just tried and it appears the endpoint is reachable but the response can't be parsed. I'll take a look tomorrow

andrevidela commented 5 years ago

The error comes from the fact that in the contact field. The API For NovaLabs has a field for google that isn't a string but a dictionary. Since the google field is seldom used I think I will remove it and it will not be parsed.

(Also, who uses google plus anyway?)

pjz commented 5 years ago

I's documented that way at https://spaceapi.io/pages/docs.html ... and it was useful when I set it up a few years ago.

andrevidela commented 5 years ago

Interestingly, spaceapi.net says otherwise.

Even if most the fields are parsed they aren't used. The app needs an update to the UI to show all the fields that are parsed. I also noticed that other hackerspaces are reported as "unresponsive" where they actually send data that isn't parsed correctly (for other reasons).

Here is the fix https://github.com/andrevidela/Hackerspaces-iOS/tree/fix-parsing-nova . But since the app store submission system is down for the holidays it will probably not be implemented until mid-january

pjz commented 5 years ago

Ah yes, spaceapi.net vs spaceapi.io - who wins? :)

I did wonder if other 'unresponsive's might also be having parsing problems. Maybe differentiate 'unresponsive' from 'unparseable' in the app?

Thanks for the quick response!

g5pw commented 5 years ago

Hey, just a heads-up: spaceapi.io is the up-to-date website, spaceapi.net is abandoned... the directory this app currently uses is managed by the spaceapi.io people.

For reference: Mittelab is impacted as well, probably because we return null as per specs because we don't yet support open/close notifications, so parsing fails here.

gidsi commented 5 years ago

Hey, what @g5pw says is right, additionally there seems to be a bug in the spaceapi.net documentation. The 0.13 version always had the google field and it was always an object with the key "plus".

You can find the description of the spaceApi standard here: https://github.com/SpaceApi/schema

And here is spaceapi.net from 3 years ago showing the field as it supposed to be: https://web.archive.org/web/20150301033644/http://spaceapi.net:80/documentation

Unfortunately we've lost control on the spaceapi.net domain, we have a catchall record pointing to our server but the a record for the top domain points somewhere else. If we regain control we're going to fix that but for right now we can't do anything beside moving over to the spaceapi.io domain, but its still the same project :)

If you want to participate feel free to join us on irc or chat.spaceapi.io or the github org https://github.com/SpaceApi.

Regards,

Timm

dbrgn commented 5 years ago

The "authoritative" specification is this "JSON Schema" file: https://github.com/SpaceApi/schema

We built a very raw validator here: https://spaceapi.io/pages/validator.html It definitely needs some love, so if someone is up for it, the very hacky sourcecode is here. It uses the validator API here.