zhafen / galaxy-dive

A general analysis package for analyzing hydrodynamic simulations of galaxy formation.
MIT License
0 stars 0 forks source link

Incorrect Temperature calculation #15

Open zhafen opened 6 years ago

zhafen commented 6 years ago

Originally reported by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)


There's a possibility I'm sometimes using a wrong calculation for the temperature.

The default (as used by C-A, Phil, and Alex R) for helium usually uses (1.+4.*yhelium)/(1.+yhelium+num_e) for mu, with yhelium = mass_fraction_helium/4(1-mass_fraction_helium). I use this when reading snapshots, but it looks like I use something different in other cases. What's right?