search

zhafen / galaxy-dive

A general analysis package for analyzing hydrodynamic simulations of galaxy formation.
MIT License
0 stars 0 forks source link

Allow choice of halo finder for galaxy associations #16

Open zhafen opened 6 years ago

zhafen commented 6 years ago

Originally reported by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

Currently only AHF is supported, but it would be good to have Rockstar and other halo finders supported.

Note that if I'm updating the postprocessing (currently AHFUpdater) as well, then I'll need to fix the following issue at line ~70 of ahf_updater.py:

 71         # Figure out if there are any valid halos at this redshift if not, then a *lot* can be skipped.
 70         # TODO: Don't hard-code this in....                                     
 69         valid_halos = self.halos['n_star'] >= 10                                
 68         no_valid_halos = valid_halos.sum() == 0                                 
 67         blank_array = np.array( [ np.nan, ]*self.halos.index.size )