read_data.snapshot.readsnap should be cleaned up and the output reformatted

zhafen / galaxy-dive

A general analysis package for analyzing hydrodynamic simulations of galaxy formation.

MIT License

0 stars 0 forks source link

read_data.snapshot.readsnap should be cleaned up and the output reformatted #2

Open zhafen opened 7 years ago

zhafen commented 7 years ago

Originally reported by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

The variable names should be consistent with the ones used in galaxy_diver.analyze_data, and the output shouldn't have the header and the data lumped together. Also, it might be modified to only load the data needed at the time.

Bitbucket: https://bitbucket.org/zhafen/galaxy_diver/issue/2

zhafen commented 7 years ago

Original comment by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

After doing some tests, readsnap is loading things fine after all, so this is back to being a low priority.

zhafen commented 7 years ago

Original comment by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

This may actually be a major part of the memory errors we're getting. Readsnap should also be updated to use context managing.