search

zhafen / linefinder

A tool for finding and classifying the worldlines of Lagrangian parcels of mass, in the context of hydrodynamic simulations of galaxy formation.
https://zhafen.github.io/linefinder
MIT License
0 stars 1 forks source link

Refactor to be clean and flexible. #103

Closed zhafen closed 9 months ago

zhafen commented 3 years ago

linefinder suffers from two primary related issues: A) Running linefinder can be a relatively involved process including using jug properly. B) Additional post- or pre-processing is usually necessary to interpret the results. Combined these discourage use.

The proposed roadmap for addressing these two problems is:

  1. Establish an alternative means to running a pipeline. Consider e.g. pypet.
  2. Enable post- and pre-processing as part of the alternative means for running the pipeline.
  3. Cut out or make optional the components of linefinder. This includes classification.
  4. Switch dependency on galaxy_dive to a dependency on yt.

This is related to Issues #9, #22, #97, and #101 .

zhafen commented 3 years ago

After looking into pypet, I think it's probably just too much. It's able to do too much, and therefore likely prone to breaking. Instead I'll focus on using minimal code, probably trove+jug+a dictionary of core arguments.