zhafen / linefinder

A tool for finding and classifying the worldlines of Lagrangian parcels of mass, in the context of hydrodynamic simulations of galaxy formation.
https://zhafen.github.io/linefinder
MIT License
0 stars 1 forks source link

Sampling IDs fails when selecting only either gas or stars #64

Open zhafen opened 6 years ago

zhafen commented 6 years ago

Originally reported by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)


In IDSampler.identify_duplicate_ids() we find the intersection of all particle types to avoid selecting duplicates where one is a star and one is gas particle. However, when we select only one particle type to track this backfires and we instead find the intersection of one set with itself and count those as duplicates. This ends up in not selecting any particles.