CGM EP and NEP classifications should be done specific to the relevant redshift

zhafen / linefinder

A tool for finding and classifying the worldlines of Lagrangian parcels of mass, in the context of hydrodynamic simulations of galaxy formation.

https://zhafen.github.io/linefinder

MIT License

0 stars 1 forks source link

CGM EP and NEP classifications should be done specific to the relevant redshift #68

Closed zhafen closed 6 years ago

zhafen commented 6 years ago

Originally reported by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

Right now they're specific to z=0.

Bitbucket: https://bitbucket.org/zhafen/pathfinder/issue/68

zhafen commented 6 years ago

Original comment by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

Done.

zhafen commented 6 years ago

Original comment by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

Easiest way to probably change this: Refactor Classifier.identify_unaccreted_EP() into two smaller functions: Classifier.identify_instant_EP() and Classifier.identify_unaccreted_EP(), and identify_instant_EP is basically what we want.