The classification `is_in_CGM` is currently too restrictive.

zhafen / linefinder

A tool for finding and classifying the worldlines of Lagrangian parcels of mass, in the context of hydrodynamic simulations of galaxy formation.

https://zhafen.github.io/linefinder

MIT License

0 stars 1 forks source link

The classification `is_in_CGM` is currently too restrictive. #92

Closed zhafen closed 6 years ago

zhafen commented 6 years ago

Originally reported by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

The CGM is anything outside the galaxy and inside the 0.1 - 1 Rvir. Currently though is_in_CGM tracks inside 0.1 - 1 Rvir with a density nH > 0.1 /cm^-3. These are not the same.

Bitbucket: https://bitbucket.org/zhafen/pathfinder/issue/92

zhafen commented 6 years ago

Original comment by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

Actually fixed Issue #92 .

zhafen commented 6 years ago

Original comment by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

Fixed Issue #92 (correct CGM classification).