search

zhammer / morning-cd

What was the first piece of music you listened to this morning?
MIT License
4 stars 0 forks source link

Empty note sent from client as empty string #110

Closed zhammer closed 5 years ago

zhammer commented 5 years ago

https://github.com/zhammer/morning-cd/blob/master/web_client/src/services/api/morningCd.tsx#L74

Technically the schema allows for this to be null. Not sure how important the difference between empty string and null is at the moment.

zhammer commented 5 years ago 
morningcd=> select count(*) from listens where note = '';
 count 
-------
   212
(1 row)

morningcd=> select count(*) from listens where note is null;
 count 
-------
     7
(1 row)
zhammer commented 5 years ago

closing for now since this doesnt really matter and could easily be fixed in db and client