zhangao0086 / DKImagePickerController

Image Picker Controller for iOS written in Swift 4 & 5.
MIT License
1.49k stars 471 forks source link

issue on video selection #160

Closed realanalysis closed 8 years ago

realanalysis commented 8 years ago

hi, on video selection, you should display max videos limit reached instead of max photos limit reached

zhangao0086 commented 8 years ago

I'll change

"maxLimitReachedMessage" = "You can select %ld photos";

to

"maxLimitReachedMessage" = "You can select %ld items";

What do you think?

realanalysis commented 8 years ago

it will be great, if you allow user to add their own message on the alert view. What do you think?

realanalysis commented 8 years ago

here is another problem, if user select one item, will you change items to item? 如果可以让dev自己填写自己想要的alert view message会比较好

zhangao0086 commented 8 years ago

Sounds good to me. 我会让用户去处理这种行为.

zhangao0086 commented 8 years ago

Now users can customize the process of didReachMaxLimit via DKImagePickerControllerDefaultUIDelegate:

The following code is the default implementation:

public func imagePickerControllerDidReachMaxLimit(imagePickerController: DKImagePickerController) {
    UIAlertView(title: DKImageLocalizedStringWithKey("maxLimitReached"),
                message: String(format: DKImageLocalizedStringWithKey("maxLimitReachedMessage"), imagePickerController.maxSelectableCount),
                delegate: nil,
                cancelButtonTitle: DKImageLocalizedStringWithKey("ok"))
        .show()
}