search

zhangfaen / finetune-Qwen2-VL

MIT License
188 stars 18 forks source link

Working with HuggingFace #6

Open wjbmattingly opened 1 month ago

wjbmattingly commented 1 month ago

Hi, thanks for this wonderful script! This was really helpful for me to get a fine-tuning pipeline working. I'd like to share my work, but wanted to share it here first and make sure proper credit was given. This is the repo below:

https://github.com/wjbmattingly/qwen2-vl-finetune-huggingface

As you can see, I've made substantial modifications and added an app for fine-tuning. Would you be interested in a PR that provides the training script for HF here? I can modify it to align with your workflow.

zhangfaen commented 1 month ago

Hi William, I am very happy that my repo is helpful. Your PR will be a great addtional value to this repo, looking forward to that.

wjbmattingly commented 1 month ago

Thanks! I didn't see your license on this code. Is it okay with you if I share this work? And do you like the way I gave your work credit? If not, please let me know how I can expand it.

zhangfaen commented 1 month ago

Hi William, I added a MIT LICENSE file in my repo. I just had a look at your repo, thank you for mentioning my repo in the README of your repo. That way is OK.

wjbmattingly commented 1 month ago

Thanks for the quick response! I'll be in touch about a PR soon! =)

zhangfaen commented 1 month ago

Cool, looking forward to that.