search

zhanghai / MaterialFiles

Material Design file manager for Android
https://play.google.com/store/apps/details?id=me.zhanghai.android.files
GNU General Public License v3.0
5.86k stars 397 forks source link

[Feature Request, Security] Allow to ask for ssh key password on-demand (sftp) #1041

Open leso-kn opened 11 months ago

leso-kn commented 11 months ago

First of all, thanks for this extraordinarily well-focussed file manager!

I'd like to suggest a feature, I believe the effort should be rather low:

Feature

When adding a new sftp connection using a password-protected ssh-key, it would be nice to have the option to leave the password blank (not store the password in the app) and be prompted whenever a connection is attempted.

Current behaviour

The current behaviour of the app is to reject saving the connecting as the ssh-key cannot be decrypted without a password.

Screenshot

Estimated effort

The highest effort in implementing this feature would probably be the additional UI of showing a password prompt upon connection. It would however be very useful security-wise. Again, thank you very much for creating this app! :)

leso-kn commented 3 months ago

@zhanghai With the recent fixes on sftp and smb, would this be an interesting feature to add before the removal of Material Design 2? To have sftp shares in an excellent state before moving to the new design?