zhanghai / MaterialFiles

Material Design file manager for Android
https://play.google.com/store/apps/details?id=me.zhanghai.android.files
GNU General Public License v3.0
6.07k stars 410 forks source link

Add get it on github badge to Readme #1118

Closed inson1 closed 9 months ago

zhanghai commented 9 months ago

Do you have a link to an official badge image for that?

inson1 commented 9 months ago

@zhanghai I dont think github has it somewhere, so use this link or save it to reposiory and use it https://i.ibb.co/q0mdc4Z/get-it-on-github.png

zhanghai commented 9 months ago

What is the license of this image?

Meanwhile, the image has a whitish background so that it won't work well for people using dark mode. The image has to be something with a transparent background.

inson1 commented 9 months ago

@zhanghai this guy is saying its from him and that is under Creative Commons license v4

https://github.com/Kunzisoft/Github-badge

you may use the svg, but your other badges seem to have same problem

zhanghai commented 9 months ago

I don't think my other badges have the same issue though because obviously Google Play and F-Droid is okay with people using their badges.

inson1 commented 9 months ago

@zhanghai I meant with "Meanwhile, the image has a whitish background so that it won't work well for people using dark mode. The image has to be something with a transparent background." Both other badges have it too.

zhanghai commented 9 months ago

@zhanghai I meant with "Meanwhile, the image has a whitish background so that it won't work well for people using dark mode. The image has to be something with a transparent background." Both other badges have it too.

The other badges have transparent background at least on my end. I'm using dark mode so it's obvious to me.