search

zhanghai / MaterialFiles

Material Design file manager for Android
https://play.google.com/store/apps/details?id=me.zhanghai.android.files
GNU General Public License v3.0
6.07k stars 410 forks source link

Black theme not working any more after updating to 1.7.0 #1151

Closed D3SOX closed 8 months ago

D3SOX commented 8 months ago

I'm using CalyxOS (Android 14) on my Pixel 8 Pro. I have enabled the setting to use a black background with the dark theme in the system settings. Furthermore, I think that's a patch which is also present in LineageOS because GrapheneOS didn't have it.

With the previous version it either used the black from my system as background color or the toggle “Black night mode” in settings worked accordingly. But now it's using a gray and when I enable “Black night mode” it falls back to the blue Material Design 2 theme.

I could also test this on my OnePlus 8T running LineageOS that's on Android 13 if needed.

zhanghai commented 8 months ago

I'm using stock OxygenOS Android 14 on my OnePlus 12 and it's working fine for me, MD3 + night mode + black. I checked on OxygenOS Android 9 on my OnePlus 5 and it's working fine as well. I wasn't able to reproduce your bug on a Pixel 2 API 34 emualtor either.

Screenshot_20240311_175112

Maybe you had a recent CalyxOS update that broke apps? And does downgrading Material Files fix the issue for you?

D3SOX commented 8 months ago
This is the toggle I'm talking about

![image](https://github.com/zhanghai/MaterialFiles/assets/24937357/59411788-c9a3-48e6-b410-b23eec72ba78)

https://github.com/zhanghai/MaterialFiles/assets/24937357/fad6421b-c0c3-41e9-b0e6-8326738bd414

Can reproduce the exact same behavior on my OnePlus 8T running LineageOS 20 (Android 13) Does not happen on 1.6.2

zhanghai commented 8 months ago

Oh nevermind I reproduced it, it's probably due to resource shrinking in release mode which got more agressive without me noticing...

zhanghai commented 8 months ago

This issue has been fixed in code now. I'll wait for a few more days for people to report other potential issues and make a hot-fix release later this week.

solgzr commented 8 months ago

I don't know if this is related, but custom accent colors aren't working either. Or if that's intentional, since the feature will be deprecated in future release?

zhanghai commented 8 months ago

That's unintended and I believe it's this same resource shrinking issue.

rywz commented 8 months ago

This issue has been fixed in code now. I'll wait for a few more days for people to report other potential issues and make a hot-fix release later this week.

I'm using the latest build and yes, it's fixed now, didn't counter any other issues tho.

zhanghai commented 8 months ago

@rywz How are you using the latest build, is that a release build? This issue only appeared on release builds.

rywz commented 8 months ago

@rywz How are you using the latest build, is that a release build? This issue only appeared on release builds.

I meant the latest build in GitHub actions.

zhanghai commented 8 months ago

I see, that's debug build and would never have this issue.