search

zhanghai / MaterialFiles

Material Design file manager for Android
https://play.google.com/store/apps/details?id=me.zhanghai.android.files
GNU General Public License v3.0
6.11k stars 413 forks source link

[Feature Request] implement ability to encrypt/decrypt files #267

Open digital-mystik opened 4 years ago

digital-mystik commented 4 years ago

Hello,

I really like the application; just was wondering if file encryption could be supported down the line. Maybe some form of using passwords and/or android keystore.

Thanks

MuntashirAkon commented 4 years ago

Encryption should support OpenKeyChain as well.

Akhilesh-T commented 3 years ago

So, are you going to implement this feature, @zhanghai?

sudomain commented 3 years ago

@zhanghai Would a PR that uses OpenKeychain for the crypto be accepted? I'm not sure if I have the ability/time to do so right now, but I'll give it a shot if I knew encryption was a feature this app plans to support.

zhanghai commented 3 years ago

Sorry no, because my current major priorities are:

Adding encryption would likely involve significant changes to the code, especially changes related to the underlying FS architecture/implementation & how the UI interacts with it, so I don't have the time to review/modify/maintain it for now. However if you have examples on how it is done in other apps (either UI or code), I may take a look and it would help me plan this feature accordingly.

Akhilesh-T commented 3 years ago

Check out Amaze File Manager

It has the file/folder encryption feature.

sudomain commented 3 years ago

OpenKeychain has an OpenPGP API which

provides methods to execute OpenPGP operations, such as sign, encrypt, decrypt, verify, and more without user interaction from background threads.

I realize I'm just a user of this app, but I feel strongly about utilizing a dedicated encryption app for this. OpenKeychain has integrations with many other apps including email clients and password managers.

Suggestion 1: a setting to let users choose an app to use for encryption/decryption. This will allow users the choice to use Material Files internal crypto (when implemented) or an external app such as OpenKeychain (OKC).

However if you have examples on how it is done in other apps (either UI or code), I may take a look and it would help me plan this feature accordingly.

Encrypting with currently works fine by selecting file(s) in Material Files and sharing them with the option "Encrypt with OpenKeychain"

Currently (starting from Material Files) we can decrypt one or more encrypted .pgp files produced by OpenKeychain with just a few taps (assuming we have the correct key), so I wouldn't change that. Once decrypted, OKC gives us the option to "Open with", "Share", and "Save": Screenshot_2021-04-13-10-20-57

This might also require some work on the OKC side of things, but the following are suggestions for how Material Files can recieve these decrpyted files from OKC (I think Material Files just needs a target activity to recieve them):

Suggestion 2: The above "Save" button should open Material Files to select a location to save to.

Suggestion 3: The "Open with" button should let us select Material Files to be able to explore a .tar, .gz, or .zip without writing it to shared storage. Currently, when Material Files "opens" a one of these files without explicitly extracting/decompressing it, does it just cache the result in it's internal storage? Whatever is happening, I'd like to also happen when I "open with" Material Files.