zhanghang1989 / PyTorch-Encoding

A CV toolkit for my papers.
https://hangzhang.org/PyTorch-Encoding/
MIT License
2.04k stars 450 forks source link

Make compatible with pytorch 1.11 and newer; bugfix #418

Closed krrish94 closed 1 year ago

krrish94 commented 1 year ago

The current version is incompatible with pytorch 1.11 and newer due to breaking changes.

Two commits feature in this PR

The first commit enables compatibility with newer pytorch versions (Issue #411)

https://github.com/zhanghang1989/PyTorch-Encoding/commit/45d5f8cc3d932faafd98f5b427b30800a2f667fd

The other commit fixed this bug https://github.com/zhanghang1989/PyTorch-Encoding/commit/00167dc4b4338f332f74b9e0dda34a5cdb5f5e84

Tested this out, and it compiles and runs on pytorch 1.11 and 1.13

krrish94 commented 1 year ago

Nudging to see if this can be merged into main.

It is a few-line fix that makes compatible with newer pytorch versions

zhanghang1989 commented 1 year ago

@krrish94 Thanks for the fix. Sorry for the delay.