zhanghao-njmu / SCP

An end-to-end Single-Cell Pipeline designed to facilitate comprehensive analysis and exploration of single-cell data.
https://zhanghao-njmu.github.io/SCP/
GNU General Public License v3.0
357 stars 81 forks source link

RunPAGA with pancreas_sub occurred error;and RunSCVELO with pancreas_sub occurred error #126

Closed DocMonster77 closed 12 months ago

DocMonster77 commented 1 year ago

pancreas_sub <- RunPAGA(srt = pancreas_sub, group_by = "SubCellType", linear_reduction = "PCA", nonlinear_reduction = "UMAP") 'misc' slot is not converted. 'tools' slot is not converted. Error in match.arg(arg = layer, choices = Layers(object = object, search = FALSE)) : 'arg' should be one of “counts”, “data”, “scale.data”

DocMonster77 commented 1 year ago

pancreas_sub <- RunSCVELO(

Yuuuushan commented 1 year ago

I have the same question using RunSCVELO. Did you solve it?

a347045077 commented 1 year ago

I have also meet the same question using RunSCVELO, How to solve it?

jerryzuo0214 commented 12 months ago

Detail: After a through debug, I have located the bug at SeuratObject::AddMetadata as well as SeuratObject::LayerData under Seurat main Version 5, the underlying bug of above two functions caused this issue. Bug Location: Unless the author change the Metadata embedding approach of SCP::adata_to_srt() [ --Line89: srt[["RNA"]] <- AddMetaData(srt[["RNA"]], metadata = as.data.frame(py_to_r_auto(adata$var))) ] , the issue might continue to appear.

Solution: A compromise is to downgrade Seurat to 4.3.1 via install.packages("Seurat") and downgrade the SeuratObject via remotes::install_github("mojaveazure/seurat-object")

jerryzuo0214 commented 12 months ago

As I mentioned above, the main version transition have caused many parameters' change in some functions, and LayerData will use layer-parameter instead of slot-parameter in the future, even though I do not have time to dig out the underlying conflict of the parameters' transition, there just true that the issue solved when I downgrade the Seurat as well as SeuratObject.

zhanghao-njmu commented 12 months ago

Apologies for the delayed response. Currently, SCP only supports Seurat v4. However, I will definitely consider adding support for Seurat v5 once it has a stable release. It's important to stay updated with the latest versions of packages to ensure compatibility and take advantage of new features. If you have any other questions or need further assistance, please let me know.

Jzwing commented 9 months ago

I changed Seruat v5(Automaticly installed by SCP Env_ solution ), I reinstalled it with Seuart V4, But when I library(SCP) Error: package or namespace load failed for ‘SCP’: object ‘LayerData<-’ is not exported by 'namespace:SeuratObject' How to fix this?

jerryzuo0214 commented 9 months ago

I changed Seruat v5(Automaticly installed by SCP Env_ solution ), I reinstalled it with Seuart V4, But when I library(SCP) Error: package or namespace load failed for ‘SCP’: object ‘LayerData<-’ is not exported by 'namespace:SeuratObject' How to fix this?

Due to the version matching issue,you likely have installed a higher version of SeuratObject,thus a downgrade might be helpful.