zhangjiacool / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Add support for app extensions #435

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
iOS 8 adds app extensions, but GYP cannot generate project files with them. It 
is a new product type of "com.apple.product-type.app-extension", and it 
includes a copy files phase that copies the generated .appex code into the 
.app's build folder.

Original issue reported on code.google.com by geor...@google.com on 10 Jun 2014 at 7:11

GoogleCodeExporter commented 9 years ago
Attached, please find a patch that basically works, but is probably missing 
some stuff since I don't know my way around the gyp code very well.

Also, I meant to make this issue an Enhancement, not a Defect. Sorry about that.

Original comment by geor...@google.com on 10 Jun 2014 at 9:51

Attachments:

GoogleCodeExporter commented 9 years ago
Hi georgen@,

Never mind, I've updated the category to Type-Enhancement.

And thank you for your patch.  Just FYI, any update on this issue tracker is 
not automatically forwarded into the developers' ML, which means that most of 
core developers still are not aware of your patch.
https://groups.google.com/forum/#!forum/gyp-developer

So I guess you need to send a codereview request to relevant people who should 
have good knowledge about the code being patched, or at least let these experts 
know about the issue reported and your patch.  I've CC-ed mark@, who seems to 
be the top contributor of pylib/gyp/generator/xcode.py, according to the 
following page.
https://code.google.com/p/gyp/source/list?path=/trunk/pylib/gyp/generator/xcode.
py

(If you want to send a codereview request, you can find a detailed instructions 
how to send a code review request here. 
https://code.google.com/p/gyp/wiki/GypHacking )

Mark: I guess you or someone you know is the best reviewer for this patch.  
What do you think about this issue and the patch?

Original comment by yukawa@chromium.org on 14 Jun 2014 at 7:55

GoogleCodeExporter commented 9 years ago
I think that this is addressed by https://codereview.chromium.org/376603002/

Original comment by mark@chromium.org on 21 Jul 2014 at 8:32

GoogleCodeExporter commented 9 years ago
https://codereview.chromium.org/376603002/ has been submitted, marking as 
resolved.

Original comment by sdefresne@chromium.org on 24 Jul 2014 at 8:12